Sung/vscode-env-vars #4803
Merged
Sung/vscode-env-vars #4803
+25
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g/vscode-env-vars
treysp
approved these changes
Jun 24, 2025
Co-authored-by: Trey Spiller <[email protected]>
Co-authored-by: Trey Spiller <[email protected]>
Co-authored-by: Trey Spiller <[email protected]>
benfdking
reviewed
Jun 25, 2025
docs/guides/vscode.md
Outdated
| - Set the environment variables in the python environment that the extension uses. You can find detailed instructions [here](https://code.visualstudio.com/docs/python/environments#_environment-variables) | ||
|
|
||
| ### Python environment woes | ||
| #### Troubleshooting Environment Variables |
There was a problem hiding this comment.
This feels like a slightly werid hierarchy:
Troublehsooting
Environment variables
Troubleshooting
There was a problem hiding this comment.
removed subheader
docs/guides/vscode.md
Outdated
Comment on lines
158
to
160
| - Open VSCode from a terminal that sets environment variables in its configuration file (e.g., `.bashrc` for Bash or `.zshrc` for Zsh). The variables will automatically be picked up by the language server only if you explicitly export them in the shell configuration file like `export ENV_VAR=value`. | ||
| - Use environment variables pulled from somewhere else dynamically (e.g. a `.env` file) in your root project directory. This will automatically be picked up by the language server. | ||
| - Set the environment variables in the python environment that the extension uses. You can find detailed instructions [here](https://code.visualstudio.com/docs/python/environments#_environment-variables) |
There was a problem hiding this comment.
This isn't quite what was intended beforehand, but I'm happy to clarify it.
- Open VSCode from a terminal that has the variables set is not about opening shells that have the variables set, if you open VSCode from a terminal with env vars set, it inherits them.
That's different to
-
The LSP server runs in your shell, and anything you have configured in there gets picked up
-
You can manually pull in vars in a Python config file as you wish.
-
.envgets pulled because of the Python environment setup. It's not a separate thing. That's how it's being pulled in
There was a problem hiding this comment.
Thanks! Updated for accuracy.
docs/guides/vscode.md
Outdated
| 3. Print the environment variables based on the instructions above to verify the changes have taken effect. | ||
|
|
||
| ### Python environment troubleshooting |
There was a problem hiding this comment.
nit: Same here RE title
Troubleshooting
Python environment troubleshooting
The additional troubleshooting feels a little redundant.
There was a problem hiding this comment.
replaced with "issues"
…sqlmesh into sung/vscode-env-vars
…g/vscode-env-vars
benfdking
reviewed
Jun 25, 2025
Co-authored-by: Ben <[email protected]>
Co-authored-by: Ben <[email protected]>
benfdking
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the newest updates to env var debugging with the extension.