🚨 Add eslint config and fix warnings

TobitSoftware · Nov 29, 2021 · 0a4d42d · 0a4d42d
1 parent 7c212fe
commit 0a4d42d
Show file tree

Hide file tree

Showing 5 changed files with 58 additions and 3 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -1,5 +1,5 @@
 {
-	"extends": "./eslint",
+	"extends": "@chayns-toolkit",
 	"globals": {
 		"__PKG_VERSION__": true
 	},

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -99,6 +99,7 @@
 		"webpack-dev-server": "^4.6.0"
 	},
 	"devDependencies": {
+		"@chayns-toolkit/eslint-config": "^2.0.0",
 		"@types/cli-table": "^0.3.0",
 		"@types/cssnano": "^4.0.1",
 		"@types/dotenv-webpack": "^7.0.3",
@@ -112,6 +113,7 @@
 		"@types/tcp-port-used": "^1.0.0",
 		"@types/webpack-bundle-analyzer": "^4.4.1",
 		"@types/webpack-dev-server": "^4.5.0",
+		"@typescript-eslint/parser": "^5.4.0",
 		"chalk": "^5.0.0",
 		"cli-table": "^0.3.9",
 		"commander": "^8.3.0",

diff --git a/src/commands/devCommand.ts b/src/commands/devCommand.ts
@@ -95,7 +95,7 @@ export function devCommand({
 					overlay: false,
 				},
 				server: {
-					type: Boolean(cert && key) ? "https" : "http",
+					type: cert && key ? "https" : "http",
 					options: {
 						key,
 						cert,

diff --git a/src/commands/testCommand.ts b/src/commands/testCommand.ts
@@ -40,7 +40,7 @@ export function testCommand({
 	watch,
 	setupFile,
 }: TestOptions): (stepParams: StepParams) => Promise<void> {
-	return async ({ config, packageJson, packageManager }) => {
+	return async ({ config, packageJson }) => {
 		const babelConfig = createBabelPresetOptions({
 			packageJson,
 			transpileModules: "commonjs",