Skip to content

Commit

Permalink
Don't attempt to test append to parquet dataset in test_append_memory…
Browse files Browse the repository at this point in the history
…file_drivers (#1394)

* Don't attempt to test append to parquet dataset in test_append_memoryfile_drivers

* Remove append flag from Parquet in drvsupport
  • Loading branch information
manisandro authored May 20, 2024
1 parent d9c0523 commit 734ab02
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 8 deletions.
2 changes: 1 addition & 1 deletion fiona/drvsupport.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
# multi-layer
# ("OpenAir", "r"),
# (Geo)Parquet
("Parquet", "raw"),
("Parquet", "rw"),
# PCI Geomatics Database File PCIDSK No No Yes, using internal PCIDSK SDK (from GDAL 1.7.0)
("PCIDSK", "raw"),
# PDS PDS No Yes Yes
Expand Down
21 changes: 14 additions & 7 deletions tests/test_memoryfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,13 +280,20 @@ def test_append_memoryfile_drivers(driver, testdata_generator):
with memfile.open(driver=driver, crs="OGC:CRS84", schema=schema) as c:
c.writerecords(records1)

with memfile.open(mode='a', driver=driver, schema=schema) as c:
c.writerecords(records2)

with memfile.open(driver=driver) as c:
assert driver == c.driver
items = list(c)
assert len(items) == len(range1 + range2)
# The parquet dataset does not seem to support append mode
if driver == "Parquet":
with memfile.open(driver=driver) as c:
assert driver == c.driver
items = list(c)
assert len(items) == len(range1)
else:
with memfile.open(mode='a', driver=driver, schema=schema) as c:
c.writerecords(records2)

with memfile.open(driver=driver) as c:
assert driver == c.driver
items = list(c)
assert len(items) == len(range1 + range2)


def test_memoryfile_driver_does_not_support_vsi():
Expand Down

0 comments on commit 734ab02

Please sign in to comment.