Skip to content

Fixed another false positive (Scam Detector) #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

Zabuzard
Copy link
Member

@Zabuzard Zabuzard commented Mar 6, 2025

Fixed a false positive that flagged messages like "25$ usd" because it contains the dollar sign and usd (a suspicious keyword).

With the fix, "usd" is not considered a sus keyword anymore but instead sets the containsDollarSign flag to true as well, so they do not count twice anymore.

Config

Remove usd from the sus keyword list.

@Zabuzard Zabuzard added enhancement New feature or request priority: normal config-changes if your PR contains any changes related to config file labels Mar 6, 2025
@Zabuzard Zabuzard self-assigned this Mar 6, 2025
@Zabuzard Zabuzard requested a review from a team as a code owner March 6, 2025 08:57
@Zabuzard Zabuzard force-pushed the feature/scam_detector_more_false_positive branch from a51454f to 4cd147b Compare March 6, 2025 09:01
Copy link

sonarqubecloud bot commented Mar 6, 2025

@Zabuzard Zabuzard merged commit f173551 into develop Mar 6, 2025
11 checks passed
@Zabuzard Zabuzard deleted the feature/scam_detector_more_false_positive branch March 6, 2025 09:07
@Zabuzard Zabuzard mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config-changes if your PR contains any changes related to config file enhancement New feature or request priority: normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant