Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle test: Make esp32 build actually try to instantiate tox. #2443

Closed
wants to merge 3 commits into from

Conversation

restyled-io[bot]
Copy link

@restyled-io restyled-io bot commented Dec 1, 2023

A duplicate of #2439 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • clang-format

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/TokTok/c-toxcore.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.


This change is Reviewable

iphydf and others added 3 commits December 1, 2023 15:43
This mainly saves spam in test logs, but may save some packets here and
there, if nodes are randomly selected twice for GET_NODES and onion
routing packets.
It doesn't work, because esp32 has too little RAM (320KB). DHT is a
240KB struct, so even just allocating that immediately fails. We'll need
to think carefully about trimming that if we ever want this to work on
embedded devices.
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (7cfe35d) 74.37% compared to head (09acd21) 74.33%.

Files Patch % Lines
toxcore/onion_client.c 70.83% 14 Missing ⚠️
toxcore/pk_set.c 65.00% 14 Missing ⚠️
toxcore/onion.c 82.35% 6 Missing ⚠️
toxcore/DHT.c 89.28% 3 Missing ⚠️
toxcore/Messenger.c 66.66% 2 Missing ⚠️
toxcore/logger.c 0.00% 2 Missing ⚠️
toxav/msi.c 0.00% 1 Missing ⚠️
toxcore/network.c 66.66% 1 Missing ⚠️
toxcore/shared_key_cache.c 90.00% 1 Missing ⚠️
toxcore/tox.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2443      +/-   ##
==========================================
- Coverage   74.37%   74.33%   -0.04%     
==========================================
  Files          87       88       +1     
  Lines       26255    26395     +140     
==========================================
+ Hits        19528    19622      +94     
- Misses       6727     6773      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@restyled-io restyled-io bot closed this Dec 1, 2023
@restyled-io restyled-io bot deleted the restyled/pull-2439 branch December 1, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants