-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V4.1.0 #165
Merged
Merged
V4.1.0 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Supply limit module * Fix lint * Update test/compliances/module-supply-limit.test.ts Co-authored-by: Nakasar <[email protected]> * Fix tests * Add reference in index.js --------- Co-authored-by: Mihalis <Mihalis> Co-authored-by: Nakasar <[email protected]>
* ✨(TTL) Create contract * ➕ (TTLM) add module contract * ✅(TTL) Create basic test * ✅(TTL) Create basic test * ✨ (TTLM) add functions * Update TimeTransfersLimitsModule and add new tests * (TTL) Implement module check and transfer action functions * Move getIdentity function from AbstractModule to module itself * Remove .only from time transfer limits test Co-authored-by: Nakasar <[email protected]> * Move bindToken call to time transfer limits tests * Use storage variables to reduce gas * Add TimeTransferLimitsModule to index.js * (TLM) Update time transfers limits docs --------- Co-authored-by: kevin.thizy <[email protected]> Co-authored-by: joachimlebrun <[email protected]> Co-authored-by: Mihalis <Mihalis>
* (EML) Add exchange monthly limits compliance module * (EML) Use storage variables to reduce gas * (TEL) Add time exchange limits module * Update exchange limits modules as Ownable * Update docs of the exchange limit modules --------- Co-authored-by: Joachim <[email protected]>
* Update CHANGELOG.md * Update package.json * Update package-lock.json
Nakasar
previously approved these changes
Sep 14, 2023
Joachim-Lebrun
commented
Sep 15, 2023
Joachim-Lebrun
commented
Sep 15, 2023
looks good, do we wait to add more modules to merge to |
- implement MaxBalance Module - Test MaxBalance Module for full module coverage - Add Documentation for MaxBalance Module on docs.tokeny.com ------------ Co-authored-by: ali.arbak <[email protected]>
I merged the |
* ✨(modules) Add name to modules * Update CHANGELOG.md * ✨(modules) Add name to modules * ✨(modules) Add name to modules * ✨(modules) Add name to modules * ✨(modules) Add name to modules * ✨(module) Add name to maxBalance
* Add plug & play functions to compliance modules * Call plug & play functions before binding a module with modular compliance * Add preset completed function to max balance module
* (TFM) Add transfer fees module * Remove describe.only from unit tests * Update set fees function * Add is plug and play function
Co-authored-by: Mihalis <Mihalis>
TREX gateway
Merged
remove useless logs from tests
* ✨ () add typescript lint check on push * 🚨 () fix ts lint * 📝 (CHANGELOG) Code Quality Improvements
Update package version
Nakasar
approved these changes
Nov 10, 2023
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.1.0]
Breaking Changes
Added
Compliance Modules:
Supply Limit Module
: Restricts minting tokens beyond a specified limit.Time Transfers Limits
: Prevents holders from transferring tokens beyond a set limit within a specified timeframe.Max Balance Module
: Ensures an individual holder doesn't exceed a certain percentage of the total supply.Time Exchange Limits
: Limits token transfers on trusted exchanges within a set timeframe.Monthly Exchange Limits
: Restricts the amount of tokens that can be transferred on trusted exchanges each month.Transfer Fees
: Collects fees from transfers (issuers determine fee rates).IModule Enhancement:
function name() external pure returns (string memory _name);
. This mandates all compliance modules to declare a constant variable, e.g.,function name() public pure returns (string memory _name) { return "CountryRestrictModule"; }
.isPlugAndPlay
: Added to theIModule
interface. This function,function isPlugAndPlay() external pure returns (bool)
, indicates whether a compliance module can be bound without presetting. It is now mandatory for all compliance modules to declare this function.canComplianceBind
: Also added to theIModule
interface. Compliance modules must implementfunction canComplianceBind(address _compliance) external view returns (bool)
, which checks if presetting is required before binding a compliance module.TREXFactory Enhancements:
setIdFactory
: Sets the Identity Factory responsible for deploying token ONCHAINIDs.getIdFactory
: Retrieves the address of the associated Identity Factory.TREXGateway Contract:
DvATransferManager Contract:
DvATransferManager
contract to streamline the process of internal fund transfers needing multi-party intermediate approvals.Updates
Smart Contract Enhancements
TREXFactory:
deployTREXSuite
function to now auto-deploy a Token ONCHAINID if it's not already available (i.e., if the onchainid address in _tokenDetails is the zero address).ModularCompliance:
addModule
function to invoke the newisPlugAndPlay
andcanComplianceBind
functions, ensuring compatibility checks before binding any compliance module.Code Quality Improvements
lint:ts
) for test files, ensuring higher code quality and adherence to coding standards.push_checking.yml
GitHub Actions workflow to include automatic TypeScript linting checks on pull requests. This addition enforces coding standards and helps maintain high-quality code submissions from all contributors.