Skip to content

Commit

Permalink
Tidy
Browse files Browse the repository at this point in the history
  • Loading branch information
Tom-Newton committed Nov 14, 2023
1 parent 39dbd2b commit 023e204
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions flytepropeller/pkg/controller/nodes/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -1320,7 +1320,6 @@ func (c *nodeExecutor) HandleNode(ctx context.Context, dag executors.DAGStructur
if err := c.Abort(ctx, h, nCtx, "node failing", false); err != nil {
return interfaces.NodeStatusUndefined, err
}
nodeStatus.ClearSubNodeStatus()
nodeStatus.UpdatePhase(v1alpha1.NodePhaseFailed, metav1.Now(), nodeStatus.GetMessage(), nodeStatus.GetExecutionError())
c.metrics.FailureDuration.Observe(ctx, nodeStatus.GetStartedAt().Time, nodeStatus.GetStoppedAt().Time)
if nCtx.NodeExecutionMetadata().IsInterruptible() {
Expand All @@ -1335,7 +1334,6 @@ func (c *nodeExecutor) HandleNode(ctx context.Context, dag executors.DAGStructur
return interfaces.NodeStatusUndefined, err
}

nodeStatus.ClearSubNodeStatus()
nodeStatus.UpdatePhase(v1alpha1.NodePhaseTimedOut, metav1.Now(), nodeStatus.GetMessage(), nodeStatus.GetExecutionError())
c.metrics.TimedOutFailure.Inc(ctx)
if nCtx.NodeExecutionMetadata().IsInterruptible() {
Expand All @@ -1360,7 +1358,6 @@ func (c *nodeExecutor) HandleNode(ctx context.Context, dag executors.DAGStructur
stopped = &t
}
c.metrics.SuccessDuration.Observe(ctx, started.Time, stopped.Time)
nodeStatus.ClearSubNodeStatus()
nodeStatus.UpdatePhase(v1alpha1.NodePhaseSucceeded, t, "completed successfully", nil)
if nCtx.NodeExecutionMetadata().IsInterruptible() {
c.metrics.InterruptibleNodesTerminated.Inc(ctx)
Expand Down

0 comments on commit 023e204

Please sign in to comment.