Fix streaks graph

Tom-Newton · Mar 28, 2024 · 043c755 · 043c755
1 parent 80f509f
commit 043c755
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/deployment/stats/prometheus/flytepropeller-dashboard.json b/deployment/stats/prometheus/flytepropeller-dashboard.json
@@ -274,7 +274,7 @@
               "instant": false,
               "interval": "",
               "intervalFactor": 2,
-              "legendFormat": "other_total",
+              "legendFormat": "total_streaks",
               "metric": "",
               "query": "sum(rate(flyte:propeller:all:round:round_time_unlabeled_ms_count[5m]))",
               "refId": "D",
@@ -694,15 +694,15 @@
           "targets": [
             {
               "datasource": null,
-              "expr": "avg(flyte:propeller:all:round:streak_length_unlabeled)",
+              "expr": "sum(rate(flyte:propeller:all:round:streak_length_unlabeled[5m]))",
               "format": "time_series",
               "hide": false,
               "instant": false,
               "interval": "",
               "intervalFactor": 2,
               "legendFormat": "",
               "metric": "",
-              "query": "avg(flyte:propeller:all:round:streak_length_unlabeled)",
+              "query": "sum(rate(flyte:propeller:all:round:streak_length_unlabeled[5m]))",
               "refId": "A",
               "step": 10,
               "target": ""
@@ -711,7 +711,7 @@
           "thresholds": [],
           "timeFrom": null,
           "timeShift": null,
-          "title": "Avg streak length",
+          "title": "Streak rate",
           "tooltip": {
             "msResolution": true,
             "shared": true,
@@ -1298,7 +1298,7 @@
           "yaxes": [
             {
               "decimals": null,
-              "format": "ops",
+              "format": "none",
               "label": null,
               "logBase": 1,
               "max": null,
@@ -1406,7 +1406,7 @@
           "thresholds": [],
           "timeFrom": null,
           "timeShift": null,
-          "title": "Enqueued Workflows",
+          "title": "Workflow enqueue rate",
           "tooltip": {
             "msResolution": true,
             "shared": true,

diff --git a/stats/flytepropeller.dashboard.py b/stats/flytepropeller.dashboard.py
@@ -112,13 +112,13 @@ def error_breakdown() -> Graph:
         )
 
     @staticmethod
-    def streak_length() -> Graph:
+    def streak_rate() -> Graph:
         return Graph(
-            title="Avg streak length",
+            title="Streak rate",
             dataSource=DATASOURCE,
             targets=[
                 Target(
-                    expr="avg(flyte:propeller:all:round:streak_length_unlabeled)",
+                    expr="sum(rate(flyte:propeller:all:round:streak_length_unlabeled[5m]))",
                     refId="A",
                 ),
             ],
@@ -824,7 +824,7 @@ def core_metrics(interval: int, collapse: bool) -> Row:
                 FlytePropeller.round_rates(),
                 FlytePropeller.error_breakdown(),
                 FlytePropeller.skipped_rounds(),
-                FlytePropeller.streak_length(),
+                FlytePropeller.streak_rate(),
                 FlytePropeller.plugin_success_vs_failures(),
                 FlytePropeller.round_latency(),
                 FlytePropeller.round_latency_per_wf(),