Add a comment

Tom-Newton · Dec 13, 2023 · 3e55c74 · 3e55c74
1 parent 45b326e
commit 3e55c74
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/flytepropeller/pkg/controller/nodes/branch/evaluator.go b/flytepropeller/pkg/controller/nodes/branch/evaluator.go
@@ -129,6 +129,7 @@ func DecideBranch(ctx context.Context, nl executors.NodeLookup, nodeID v1alpha1.
 		}
 		nStatus := nl.GetNodeExecutionStatus(ctx, n.GetID())
 		logger.Infof(ctx, "Branch Setting Node[%v] status to Skipped!", skippedNodeID)
+		// TODO: What is the impact of always setting clearStateOnAnyTermination=false here? 
 		nStatus.UpdatePhase(v1alpha1.NodePhaseSkipped, v1.Now(), "Branch evaluated to false", false, nil)
 	}