Create a copy of the error to return

Tom-Newton · Nov 15, 2023 · ce097d7 · ce097d7
1 parent 07c8262
commit ce097d7
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/flytepropeller/pkg/controller/nodes/executor.go b/flytepropeller/pkg/controller/nodes/executor.go
@@ -1320,14 +1320,21 @@ func (c *nodeExecutor) HandleNode(ctx context.Context, dag executors.DAGStructur
 		if err := c.Abort(ctx, h, nCtx, "node failing", false); err != nil {
 			return interfaces.NodeStatusUndefined, err
 		}
-		nodeStartedAt := nodeStatus.GetStartedAt().Time
-		nodeError := nodeStatus.GetExecutionError()
-		nodeStatus.UpdatePhase(v1alpha1.NodePhaseFailed, metav1.Now(), nodeStatus.GetMessage(), nodeError)
-		c.metrics.FailureDuration.Observe(ctx, nodeStartedAt, nodeStatus.GetStoppedAt().Time)
+		t := metav1.Now()
+
+		started := nodeStatus.GetStartedAt()
+		if started == nil {
+			started = &t
+		}
+
+		nodeError := *nodeStatus.GetExecutionError()
+
+		nodeStatus.UpdatePhase(v1alpha1.NodePhaseFailed, t, nodeStatus.GetMessage(), nodeStatus.GetExecutionError())
+		c.metrics.FailureDuration.Observe(ctx, started.Time, nodeStatus.GetStoppedAt().Time)
 		if nCtx.NodeExecutionMetadata().IsInterruptible() {
 			c.metrics.InterruptibleNodesTerminated.Inc(ctx)
 		}
-		return interfaces.NodeStatusFailed(nodeError), nil
+		return interfaces.NodeStatusFailed(&nodeError), nil
 	}
 
 	if currentPhase == v1alpha1.NodePhaseTimingOut {