Skip to content

Commit

Permalink
Copy state when not failing immediately
Browse files Browse the repository at this point in the history
  • Loading branch information
Tom-Newton committed Nov 15, 2023
1 parent 7dbe429 commit f499406
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/nodes/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ func (c *recursiveNodeExecutor) handleDownstream(ctx context.Context, execContex
// If the failure policy allows other nodes to continue running, do not exit the loop,
// Keep track of the last failed state in the loop since it'll be the one to return.
// TODO: If multiple nodes fail (which this mode allows), consolidate/summarize failure states in one.
stateOnComplete = state
stateOnComplete = interfaces.NodeStatus{NodePhase: state.NodePhase, Err: &*state.Err}
} else {
return state, nil
}
Expand Down

0 comments on commit f499406

Please sign in to comment.