Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to clear past errors from workflow state #6

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
fea71e9
Don't track node errors
Tom-Newton Nov 15, 2023
4d1e5f6
Wipe node error after its collected
Tom-Newton Nov 15, 2023
57e12aa
Revert "Don't track node errors"
Tom-Newton Nov 15, 2023
457f0d7
Try clearing error message without breaking upstream propagation of e…
Tom-Newton Nov 15, 2023
552f413
Fix clearing error message
Tom-Newton Nov 15, 2023
83812e3
Create a copy of the error to return
Tom-Newton Nov 15, 2023
26d9d05
Working error propagates to imdiate execution
Tom-Newton Nov 15, 2023
d50598c
Tidy
Tom-Newton Nov 15, 2023
5ee89e1
Copy state when not failing immediately
Tom-Newton Nov 15, 2023
cb768a3
Reset errors only when recording a new error
Tom-Newton Nov 16, 2023
3a17f9e
Tidy
Tom-Newton Nov 16, 2023
3574d6f
White space
Tom-Newton Nov 16, 2023
63f83f2
Run each round in a sub test to make the output more interpretable
Tom-Newton Dec 19, 2023
4487db4
Make the test follow FAIL_AFTER_EXECUTABLE_NODES_COMPLETE code path
Tom-Newton Dec 19, 2023
96c5393
Small progress on the test
Tom-Newton Dec 20, 2023
2971250
Working test for error clearing
Tom-Newton Dec 21, 2023
c0eb0b1
Both test cases working
Tom-Newton Dec 21, 2023
8648de0
Tidy test
Tom-Newton Dec 21, 2023
b247ec8
Add test cases for clearPreviousError config
Tom-Newton Dec 21, 2023
41a06b1
Implement clearPreviousError config
Tom-Newton Dec 21, 2023
250a0ff
Update generated code
Tom-Newton Dec 21, 2023
345f990
Require error to be removed not just cleared
Tom-Newton Dec 21, 2023
9934791
Working remove error
Tom-Newton Dec 21, 2023
431f1d3
Remove redundant attempts
Tom-Newton Dec 21, 2023
0ce2f89
Update generated code
Tom-Newton Dec 21, 2023
99fc625
Tidy mocking
Tom-Newton Dec 21, 2023
216e1a3
Avoid making nodeExecContext public
Tom-Newton Dec 21, 2023
6c5650c
Remove `clear-previous-error` and use `enable-cr-debug-metadata` instead
Tom-Newton Jan 16, 2024
2cea075
Update test comments
Tom-Newton Jan 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Create a copy of the error to return
Signed-off-by: Thomas Newton <[email protected]>
  • Loading branch information
Tom-Newton committed Jan 16, 2024
commit 83812e31b0763da622129bb3260a4bcc4b7cd2ed
2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/nodes/executor.go
Original file line number Diff line number Diff line change
@@ -1336,7 +1336,7 @@ func (c *nodeExecutor) HandleNode(ctx context.Context, dag executors.DAGStructur
if nCtx.NodeExecutionMetadata().IsInterruptible() {
c.metrics.InterruptibleNodesTerminated.Inc(ctx)
}
return interfaces.NodeStatusFailed(nodeError), nil
return interfaces.NodeStatusFailed(&nodeError), nil
}

if currentPhase == v1alpha1.NodePhaseTimingOut {