Upgrade shaker generator to support 2.5 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix tape, to be error prone (Tom1975#14) * Fix recording, using path * Bugfix/fix tape and record (Tom1975#15) * Fix: remove accentued characters * DISABLE despotik desisgn due to non reproductible bug on CI (will be investigated later)
A, B modules are implemented
…or SFML instead of Qt (cf Sugarbox).
Add custom opcode in Shaker to handle auto printscreen
… short, but this shouldn't cause any trouble)
|
hi @Tom1975 |
Thanks for the fix for ubuntu, and the pull request. About the tests, I believe it may be due to some problems with keyboard layout (only file that change). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation is still having some timing issue (especially Module A, between test 4 and 5). With timing issues, we miss some test image generation for now... (see logs)
Core need to be fixed IMHO
I put it as draft, feedback welcomed !