added typescript types #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey sorry for the (very) late response. Do you still wish to get this in the root project? |
|
I have learned quite a bit about typescript since I wrote this PR. I should review it as I did almost no testing on it (and I barely understood how npm packages worked at the time). Let me get back to you on this.
…On Jan 26, 2023 at 1:12 AM -0700, Thomas Jarrand ***@***.***>, wrote:
Hey sorry for the (very) late response.
Do you still wish to get this in the root project?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Tom32i
force-pushed
the
master
branch
5 times, most recently
from
9a4819b
to
1251a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding type script types