Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update network_security_config.xml #433

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

coderph0x
Copy link
Contributor

@coderph0x coderph0x commented Apr 21, 2024

fix: Added user-defined certificates, so that custom CAs that are installed on the device should be respected (discussed in #236)

@thatso
Copy link

thatso commented Apr 21, 2024

@coderph0x great find! However, your reference has lines 5 and 6 swapped with user first:

<certificates src="user"/>
<certificates src="system"/>

@coderph0x
Copy link
Contributor Author

@coderph0x great find! However, your reference has lines 5 and 6 swapped with user first:

<certificates src="user"/>
<certificates src="system"/>

Hope this isn't too relevant. Unfortunately, setting up the dev environment failed for me, so I wasn't able to test this.

Added user-defined certificates, so that custom CAs that are installed on the device should be respected
@TomBursch
Copy link
Owner

Thanks for the PR, I'm still not sure if this will actually fix #236. The issue you've linked talks only about webview which likely uses an android native library. For connecting to the server, KitchenOwl uses the HTTP client written in dart. This is definitely needed anyway, but I'm not sure if the dart HTTP client can use the added certificates. We'll see 😄

@TomBursch TomBursch merged commit 88eff03 into TomBursch:main Apr 24, 2024
2 checks passed
@TomBursch TomBursch added the bug Something isn't working label Apr 24, 2024
@coderph0x coderph0x deleted the patch-1 branch April 25, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants