Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer toolbar #337

Closed
wants to merge 14 commits into from
Closed

Conversation

Dagonite
Copy link

Implementation of the viewer GUI toolbar.

@lauramurgatroyd
Copy link
Member

Hi @Dagonite, thanks for opening the PR! We have a training course/hackathon coming up soon for our CIL software, so we are pretty busy over the next few weeks. This means we probably won't get on to looking at this yet, but we will get back to it after then!

Copy link
Member

@lauramurgatroyd lauramurgatroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we cannot yet use imports from vtkmodules as we still have to support vtk8 for the iDVC app.

Instead we need to use: colors = vtk.vtkNamedColors()

This requires some more changes rather than just the import change so I will look into this another time

@lauramurgatroyd lauramurgatroyd marked this pull request as draft April 13, 2023 14:43
@lauramurgatroyd lauramurgatroyd added this to the Version 23.2.0 milestone Apr 14, 2023
@lauramurgatroyd
Copy link
Member

This will close #331

@paskino paskino mentioned this pull request Jun 15, 2023
3 tasks
@paskino
Copy link
Collaborator

paskino commented Jun 16, 2023

Relevant changes are updated in #347

@paskino paskino closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants