-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make raw dialog settings saveable #444
base: master
Are you sure you want to change the base?
Conversation
These are workarounds to be able to configure the volume render
Suggestions from @paskino:
|
I have made the suggested changes and updated the PR description accordingly |
I believe requires #446 for action to pass |
def __init__(self, parent, fname, qsettings): | ||
super(SaveableRawInputDialog, self).__init__(parent, fname) | ||
|
||
self.settings = qsettings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we create a qsettings in here if one isn't passed in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test this case
Describe your changes
Closes #443
I updated standalone viewer to use this dialog.
To try it out yourself:
to discuss
pic of the dialog:
The pop out dialog if you press save:
Describe any testing you have performed
Consider adding example code to examples
Added unit tests to test:
Link relevant issues
Checklist when you are ready to request a review
Contribution Notes
Qt contributions should follow Qt naming conventions i.e. camelCase method names.
VTK contributions should follow VTK naming conventions i.e. PascalCase method names.