Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration box becomes opaque after pressing 's' #179

Closed
lauramurgatroyd opened this issue Jan 10, 2023 · 4 comments · Fixed by #218
Closed

Registration box becomes opaque after pressing 's' #179

lauramurgatroyd opened this issue Jan 10, 2023 · 4 comments · Fixed by #218
Assignees
@DanicaSTFC
Labels
bug Something isn't working registration This label refers to the registration process
Milestone
Next version

Comments

@lauramurgatroyd
Copy link
Member

can press 'w' to change it back to wireframe, but this should happen automatically
@lauramurgatroyd lauramurgatroyd converted this from a draft issue Jan 10, 2023
@lauramurgatroyd
Copy link
Member Author

See TomographicImaging/CILViewer#331 - having a toolbar with settings means they will no longer use the 's' keypress

@lauramurgatroyd lauramurgatroyd moved this from Todo - Bug fixes to TODO - viewer issues in iDVC Planning Jan 10, 2023
@paskino
Copy link
Contributor

paskino commented Feb 6, 2023

Work is in progress in removing the key presses and adding a tool bar in the viewer.

@lauramurgatroyd
Copy link
Member Author

Another problem is although it changes to wireframe when 'w' is pressed, this also changes the vectors on the 3D view to wrireframe as well, which we don't want as the arrows are difficult to see in wireframe

@DanicaSTFC DanicaSTFC self-assigned this Nov 24, 2023
@DanicaSTFC DanicaSTFC added the bug Something isn't working label Nov 24, 2023
@DanicaSTFC DanicaSTFC added this to the Next version milestone Nov 24, 2023
@DanicaSTFC DanicaSTFC added the registration This label refers to the registration process label Nov 24, 2023
@paskino
Copy link
Contributor

paskino commented Jan 10, 2024

We should intercept the keypress w and s and consume it.

@paskino paskino moved this from TODO - viewer issues to In Progress in iDVC Planning Jan 12, 2024
@paskino paskino mentioned this issue Jan 12, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in iDVC Planning Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanicaSTFC DanicaSTFC

Labels
bug Something isn't working registration This label refers to the registration process
Projects
iDVC Planning
Archived in project
Milestone
Next version
Development

Successfully merging a pull request may close this issue.

consume CharEvents s and w in viewers TomographicImaging/iDVC
3 participants
@paskino @lauramurgatroyd @DanicaSTFC