consume CharEvents s and w in viewers #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanicaSTFC
approved these changes
Jan 15, 2024
DanicaSTFC
requested changes
Jan 15, 2024
There was a problem hiding this comment.
When I run the app the terminal shows:
- "Unhandled event w" when "w" is pressed in the 3D viewer.
Can we change this so this is not printed? I noticed this sentence is printed for most keys pressed in the 3D viewer.
When I pressed "q" on the 3D viewer the app stopped responding. Is this something similar to the w behaviour we could avoid?
|
The prints "unhandled event w" comes from the viewer, so it should be updated there.
I'll investigate. |
DanicaSTFC
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #179
Adds parsing of CLI parameters to idvc executable.
Currently adds the way to set the global logging level.