Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Javadoc method definition add modifier #801

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix: Javadoc method definition add modifier #801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/java/com/ly/doc/template/IJavadocDocTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ default JavadocJavaMethod convertToJavadocJavaMethod(ApiConfig apiConfig, JavaMe

default String methodDefinition(JavaMethod method, Map<String, JavaType> actualTypesMap) {
StringBuilder methodBuilder = new StringBuilder();
// append method modifiers
method.getModifiers().forEach(item -> methodBuilder.append(item).append(" "));
JavaType returnType = method.getReturnType();
String simpleReturn = replaceTypeName(returnType.getCanonicalName(), actualTypesMap, Boolean.TRUE);
String returnClass = replaceTypeName(returnType.getGenericCanonicalName(), actualTypesMap, Boolean.TRUE);
Expand All @@ -103,6 +105,8 @@ default String methodDefinition(JavaMethod method, Map<String, JavaType> actualT

}
}

// append method return type
methodBuilder.append(returnClass).append(" ");
List<String> params = new ArrayList<>();
List<JavaParameter> parameters = method.getParameters();
Expand Down Expand Up @@ -146,7 +150,6 @@ default String replaceTypeName(String type, Map<String, JavaType> actualTypesMap
if (Objects.isNull(actualTypesMap)) {
return type;
}

for (Map.Entry<String, JavaType> entry : actualTypesMap.entrySet()) {
if (type.contains(entry.getKey())) {
if (simple) {
Expand Down
Loading