Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature fieldmapping readme (PSv2) #21

Merged
merged 12 commits into from
Jul 11, 2024
Merged

Feature fieldmapping readme (PSv2) #21

merged 12 commits into from
Jul 11, 2024

Conversation

rhouthuijzen
Copy link
Contributor

Added fieldmapping
Updated readme to new template
Fixed issue (this is also solved in topdesk operator)

@rhouthuijzen
Feat: remove lookupValue in field mapping possible
5057564 
For Department and budgetHolder

Verbose messages:

Mapping of [department.lookupValue] is missing to lookup the department in Topdesk. Action skipped

Mapping of [budgetHolder.lookupValue] is missing to lookup the budgetHolder in Topdesk. Action skipped
@rhouthuijzen
Feat: added fieldMapping and updated readme
050a17a
@rhouthuijzen rhouthuijzen linked an issue Feb 14, 2024 that may be closed by this pull request
Budgetholder is queried when none is provided in account object #14
Closed
@rschouten97

This comment was marked as resolved.

Sign in to view
@rhouthuijzen rhouthuijzen linked an issue Mar 18, 2024 that may be closed by this pull request
missing mapping #22
Closed
@JeroenBL JeroenBL added the changes-requested PR has been reviewed and requires additional work before approval label Jun 3, 2024
This was linked to issues Jun 19, 2024
When no field is mapped on the delete action the script fails #25
Closed
Correlation only is missing #23
Closed
@rhouthuijzen
Copy link
Contributor Author

Added necessary compare object. Tested on test portal and at two customers

@Rick-Jongbloed Rick-Jongbloed removed the changes-requested PR has been reviewed and requires additional work before approval label Jul 11, 2024
Rick-Jongbloed
Rick-Jongbloed approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@Rick-Jongbloed Rick-Jongbloed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes are implemented. Code looks good. Approved.

configuration.json Outdated Show resolved Hide resolved
delete.ps1 Outdated Show resolved Hide resolved
disable.ps1 Outdated Show resolved Hide resolved
enable.ps1 Outdated Show resolved Hide resolved
permissions/change/grantPermission.ps1 Outdated Show resolved Hide resolved
permissions/change/revokePermission.ps1 Outdated Show resolved Hide resolved
permissions/incident/grantPermission.ps1 Outdated Show resolved Hide resolved
permissions/incident/revokePermission.ps1 Outdated Show resolved Hide resolved
update.ps1 Outdated Show resolved Hide resolved
@Rick-Jongbloed Rick-Jongbloed merged commit f99bee7 into master Jul 11, 2024
@Rick-Jongbloed Rick-Jongbloed deleted the feature-fieldmapping-readme branch July 11, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rick-Jongbloed Rick-Jongbloed Rick-Jongbloed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rhouthuijzen @rschouten97 @Rick-Jongbloed @JeroenBL