Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preserve schema variables' ordering when parsing from the input YAML config file. #22

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

LinZhihao-723
Copy link
Contributor

@LinZhihao-723 LinZhihao-723 commented Dec 16, 2024

Description

Before this PR, the ordering of the given schema is not preserved because of the nature of HashMap. This PR solves the problem by using IndexMap instead to store the parsed result.

Validation performed

  • Ensure all workflows passed.
  • Ensure newly added unit tests passed that check the ordering.

@Louis-He Louis-He merged commit dcc68f3 into Toplogic-Inc:main Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants