Exchange rates api #148
Open
Exchange rates api #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torann
requested changes
Apr 12, 2022
src/Console/Update.php
Outdated
| @@ -65,8 +65,14 @@ public function handle() | |||
| $defaultCurrency = $this->currency->config('default'); | |||
|
|
|||
| if ($this->input->getOption('exchangeratesapi')) { | |||
| if (!$api = $this->currency->config('api_key')) { | |||
There was a problem hiding this comment.
This is a little messy. Please clean it up some to look more like this:
if ($access_key = $this->currency->config('api_key')) {
return $this->updateFromExchangeRatesApi($defaultCurrency, $access_key);
}
$this->error('An API key is needed from exchangeratesapi.io to continue.');
return;
Also please make the variable more description, $api doesn't make any sense for the access_key, even api_key would be better.
|
Done |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exchange API rate now need an API key