Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conjunction empty keys #11

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Conjunction empty keys #11

merged 9 commits into from
Jun 6, 2024

Conversation

PierreQuinton
Copy link
Contributor

@PierreQuinton PierreQuinton commented Jun 3, 2024 •
edited
Loading

@PierreQuinton PierreQuinton mentioned this pull request Jun 3, 2024
Merged
@ValerianRey
Copy link
Contributor

ValerianRey commented Jun 5, 2024 •
edited by PierreQuinton
Loading

Code LGTM. Tests need some changes:

  • Replace MockTensorDict by TensorDict
  • Rename MockTransform to FakeTransform
  • Add docstring to FakeTransform
  • Add docstring to each test

@PierreQuinton PierreQuinton merged commit f9853e1 into main Jun 6, 2024
2 checks passed
@PierreQuinton PierreQuinton deleted the conjunction_empty_keys branch June 6, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can Conjunction take an empty list of transforms ?
2 participants
@PierreQuinton @ValerianRey