TFM 5.0.2 Release #2176
Open
TFM 5.0.2 Release #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TFM1.13-Alpha # Conflicts: # pom.xml
…inal hard coded blocked tag list and moved to the config file
…s versions and look to have also fixed the issue with BStats
JeromSar
requested changes
Mar 18, 2019
src/main/java/me/totalfreedom/totalfreedommod/command/Command_tag.java
Outdated
Show resolved
Hide resolved
Added required new line.
…from being banned.
This should fix the memory leak I suspect.
|
|
JeromSar
requested changes
Sep 16, 2019
| { | ||
| // Load banned tags | ||
| blockedTags.clear(); | ||
| blockedTags.addAll((Collection<? extends String>) ConfigEntry.BLOCKED_TAGS.getList()); |
There was a problem hiding this comment.
You don't need a separate service for loading this list. Especially since we're never adding to it. You can simply use ConfigEntry.BLOCKED_TAGS.getList() anywhere you need it. Lookup should be pretty fast and without I/O.
There was a problem hiding this comment.
Just going to go and facepalm. Apparently I decided over-engineering it was the best way. Thanks for the heads up, I'll make appropriate changes.
|
@Wild1145 you didn’t modify to dependency to point to EssentialsX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.