Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nu-7476] Add more info about failed deployment due to wrong cron configuration #7479

Merged
merged 4 commits into from
Jan 22, 2025
Merged

[Nu-7476] Add more info about failed deployment due to wrong cron configuration #7479

merged 4 commits into from
Jan 22, 2025

Conversation

DeamonDev
Copy link
Contributor

Describe your changes

Closes #7476

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@DeamonDev DeamonDev self-assigned this Jan 20, 2025
@github-actions github-actions bot added client client main fe ui labels Jan 20, 2025
@DeamonDev DeamonDev force-pushed the nu-7476-improve-ui-errors-related-to-cron-missconfiguration branch from b3b650c to dcf3cfd Compare January 20, 2025 13:22
@DeamonDev DeamonDev marked this pull request as draft January 20, 2025 14:56
@DeamonDev DeamonDev closed this Jan 22, 2025
@DeamonDev DeamonDev reopened this Jan 22, 2025
@DeamonDev DeamonDev force-pushed the nu-7476-improve-ui-errors-related-to-cron-missconfiguration branch 3 times, most recently from 262bed2 to 2d102f5 Compare January 22, 2025 13:46
@DeamonDev DeamonDev requested a review from Dzuming January 22, 2025 13:54
@DeamonDev DeamonDev marked this pull request as ready for review January 22, 2025 13:54
@DeamonDev DeamonDev force-pushed the nu-7476-improve-ui-errors-related-to-cron-missconfiguration branch from fa50466 to a0eb118 Compare January 22, 2025 14:06
@DeamonDev DeamonDev requested a review from Dzuming January 22, 2025 14:13
Dzuming
Dzuming approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeamonDev DeamonDev merged commit b7bf64a into staging Jan 22, 2025
14 checks passed
@DeamonDev DeamonDev deleted the nu-7476-improve-ui-errors-related-to-cron-missconfiguration branch January 22, 2025 15:22
DeamonDev added a commit that referenced this pull request Jan 22, 2025
@DeamonDev @Dzuming
[Nu-7476] Add more info about failed deployment due to wrong cron con…
d4beb87 
…figuration (#7479)

* [Nu-7476] Add more info about failed deployment due to cron miss-configuration

---------

Co-authored-by: Piotr Rudnicki <[email protected]>
Co-authored-by: Dawid Poliszak <[email protected]>
DeamonDev added a commit that referenced this pull request Jan 22, 2025
@DeamonDev @Dzuming
[Nu-7476] Add more info about failed deployment due to wrong cron con…
d2cf4bc 
…figuration (#7479) (#7490)

* [Nu-7476] Add more info about failed deployment due to cron miss-configuration

---------

Co-authored-by: Piotr Rudnicki <[email protected]>
Co-authored-by: Dawid Poliszak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dzuming Dzuming Dzuming approved these changes

Assignees

@DeamonDev DeamonDev

Labels
client client main fe ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more descriptive error message to user when the deployment failed due to cron settings
2 participants
@DeamonDev @Dzuming