-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented text recognition (ocr) #272
Merged
Merged
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
efe7f73
implemented text recognition (ocr)
ston1th a00dd41
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] ead3463
fixed typo in requirements.txt and make linter happy
ston1th d36e2d4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c9766bf
keep pillow on windows and more linter fixes
ston1th 8998360
use pathlib to read file
ston1th f25fc7e
fix str None comparison
ston1th 2f8d298
rewrite some stuff
ston1th fddd0ae
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cd2c212
switch back to tesseract
ston1th 80140cb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 450b983
Merge branch 'dev' into ocr
Avasam feeb58e
internal logic changes
ston1th fb8ed6f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] da830c6
import subprocess globally
ston1th 5674088
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b5f6639
make linter happy
ston1th f1ba410
fixed typo in docstring
ston1th d1dfff0
input validation and comparison methods
ston1th f3c0e3e
fix linter
ston1th 3a3015f
Merge branch 'dev' of https://github.com/Toufool/AutoSplit into ocr
ston1th 75cd0e9
improvements to coordinates and matching methods
ston1th 7be9a0e
fix ruff linter
ston1th 043b6b5
Address my own PR comments and fix linting
Avasam c0b2920
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f2b407a
Merge branch 'dev' into ocr
Avasam 9cd0c2b
STARTUPINFO doesn't exist on Linux
Avasam 2f03a90
More explicit platform check
Avasam 797492f
Fix circular imports, mak OCR as clearly experimental
Avasam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember from last time I tested, will this override any previous image being rendered on the
QLabel
? (let's say someone has a regular split image followed by an OCR split)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I did not test this. But just to be sure we could just
None
it and then set the text.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah,
set_preview_image
avoids clearing text if you sendNone
by design.Or you could call
self.current_split_image.clear()
yourself before setting the text.If
setText
already clears the image by itself, then you don't need to do anything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't block for this with the TODO comment. Just bumping as a reminder we should test it to confirm