Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented text recognition (ocr) #272
implemented text recognition (ocr) #272
Changes from 19 commits
efe7f73
a00dd41
ead3463
d36e2d4
c9766bf
8998360
f25fc7e
2f8d298
fddd0ae
cd2c212
80140cb
450b983
feeb58e
fb8ed6f
da830c6
5674088
b5f6639
f1ba410
d1dfff0
f3c0e3e
3a3015f
75cd0e9
7be9a0e
043b6b5
c0b2920
f2b407a
9cd0c2b
2f03a90
797492f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember from last time I tested, will this override any previous image being rendered on the
QLabel
? (let's say someone has a regular split image followed by an OCR split)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I did not test this. But just to be sure we could just
None
it and then set the text.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah,
set_preview_image
avoids clearing text if you sendNone
by design.Or you could call
self.current_split_image.clear()
yourself before setting the text.If
setText
already clears the image by itself, then you don't need to do anything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't block for this with the TODO comment. Just bumping as a reminder we should test it to confirm