security: Drop stack trace from failure message (#729)

frontend/next-env.d.ts

@@ -1,5 +1,6 @@
 /// <reference types="next" />
 /// <reference types="next/image-types/global" />
+/// <reference types="next/navigation-types/compat/navigation" />
 
 // NOTE: This file should not be edited
 // see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.

frontend/src/components/executions/event-details.tsx

@@ -84,10 +84,6 @@ export function WorkflowExecutionEventDetailView({
             <AccordionContent>
               <div className="my-4 flex flex-col space-y-8 px-4">
                 <CodeBlock title="Message">{event.failure.message}</CodeBlock>
-                <CodeBlock title="Stack Trace">
-                  {event.failure.stack_trace}
-                </CodeBlock>
-                <JsonViewWithControls src={event.failure} />
               </div>
             </AccordionContent>
           </AccordionItem>

tracecat/executor/models.py

@@ -4,6 +4,8 @@
 
 from pydantic import UUID4, BaseModel
 
+from tracecat.config import TRACECAT__APP_ENV
+
 
 class ExecutorSyncInput(BaseModel):
     repository_id: UUID4
@@ -31,13 +33,16 @@ class ExecutorActionErrorInfo(BaseModel):
     """Line number where the error occurred."""
 
     def __str__(self) -> str:
-        return (
-            f"{self.type}: {self.message}"
-            f"\n\n{'-' * 30}"
-            f"\nFile: {self.filename}"
-            f"\nFunction: {self.function}"
-            f"\nLine: {self.lineno}"
-        )
+        if TRACECAT__APP_ENV == "development":
+            return (
+                f"{self.type}: {self.message}"
+                f"\n\n{'-' * 30}"
+                f"\nFile: {self.filename}"
+                f"\nFunction: {self.function}"
+                f"\nLine: {self.lineno}"
+            )
+        else:
+            return f"{self.type}: {self.message}"
 
     @staticmethod
     def from_exc(e: Exception, action_name: str) -> ExecutorActionErrorInfo:

tracecat/workflow/executions/models.py

@@ -226,9 +226,7 @@ def from_initiated_child_workflow(
 
 class EventFailure(BaseModel):
     message: str
-    stack_trace: str
     cause: dict[str, Any] | None = None
-    application_failure_info: dict[str, Any] = Field(default_factory=dict)
 
     @staticmethod
     def from_history_event(
@@ -254,9 +252,7 @@ def from_history_event(
 
         return EventFailure(
             message=failure.message,
-            stack_trace=failure.stack_trace,
             cause=MessageToDict(failure.cause) if failure.cause is not None else None,
-            application_failure_info=MessageToDict(failure.application_failure_info),
         )