Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Add template tab and fix state actions on node click #711

Merged
merged 9 commits into from
Jan 9, 2025
Merged

feat(ui): Add template tab and fix state actions on node click #711

merged 9 commits into from
Jan 9, 2025

Conversation

topher-lo
Copy link
Contributor

@topher-lo topher-lo commented Jan 8, 2025 •
edited
Loading

Before

  • Fixed state issues with error saving state and tabs selected persisting between nodes
  • Fixed tab switcher content overflowing and the content (e.g. editor) remains the same size
Screenshot 2025-01-08 at 12 17 54 PM

After

Screenshot 2025-01-08 at 1 11 05 PM

Others

  • I deleted the toast when an action has malformed YAML. The state is really janky and removes immersion i.e. too aggressive (gives me unnecessary cortisol).
  • ^I think this is feature of the past when we didn't have the really nice SaveStateIcon

@topher-lo topher-lo added enhancement New feature or request frontend Improvements or additions to the frontend labels Jan 8, 2025
@topher-lo topher-lo requested a review from daryllimyt January 8, 2025 21:21
daryllimyt
daryllimyt approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@daryllimyt daryllimyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one clarification

frontend/src/lib/hooks.tsx
Comment on lines -147 to -150
toast({
title: "Failed to save action",
description: "Could not update your action. Please try again.",
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why this was removed? is it clear enough without?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The state is janky and distracting. I think it's clear enough without because it'll get caught on "save".

@topher-lo topher-lo merged commit 66ca759 into main Jan 9, 2025
5 checks passed
@topher-lo topher-lo deleted the feat/show-template-in-action-tab branch January 9, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daryllimyt daryllimyt daryllimyt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend Improvements or additions to the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topher-lo @daryllimyt