Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tighten input validation #728

Merged
merged 24 commits into from
Jan 10, 2025
Merged

feat: Tighten input validation #728

merged 24 commits into from
Jan 10, 2025

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Jan 10, 2025 •
edited
Loading

Changes

  • Make 422 unprocessible entity errors return an object with detail field: {"detail": ...}
  • Tighten up input validation across FE zod schemas and API layer pydantic models
  • Replace certain Controller fields with shadcn FormField

Screens

Screenshot 2025-01-11 at 00 05 37

Screenshot 2025-01-11 at 00 02 34

Screenshot 2025-01-11 at 00 02 09

@daryllimyt
Add field constraints to tag API models
14c2381
@daryllimyt
Add zod max chars for tags
a5fe807
@daryllimyt
Add field constraints to workflow API models
41a1296
@daryllimyt
Add field constraints for registry action API models
0ce4e80
@daryllimyt
Add zod min/max chars for template action new/edit
863ecd0
@daryllimyt
Add action panel title and description field constraints
de0b14f
@daryllimyt
Add RequestValidationError type
47325d8
@daryllimyt
Add workflow panel title and description field constraints
fa98bd2
@daryllimyt
Add action API models field constraints
4a73037
@daryllimyt
Make 422 errors return object with detail field
76a5766
@daryllimyt
Improve error message for email login validation vs API model validat…
05e1357 
…ion error
@daryllimyt
Add field constraints to registry repo api models
f83f881
@daryllimyt
Add back null title support in workflow create
65d2bd8
@daryllimyt
Clean up yaml handling
9156ed3
@daryllimyt
Add field max length to workflow panel zod schemas
c84fbaa
@daryllimyt
Replace Controller with shadcn form fields
8c6497f
@daryllimyt
Add zod in action panel to constrain inputs
f0baec9
@daryllimyt
Add field length constraints on secrets
ea33664
@daryllimyt
Add workflow create router constraints
225ee4c
@daryllimyt
Add workspace field contraints
9b47767
@daryllimyt daryllimyt force-pushed the feat/tighten-input-validation branch from 2296dc0 to 2c15cbf Compare January 10, 2025 16:07
@daryllimyt daryllimyt changed the title Feat/tighten input validation feat: Tighten input validation Jan 10, 2025
@daryllimyt daryllimyt requested a review from topher-lo January 10, 2025 16:31
@daryllimyt daryllimyt added enhancement New feature or request frontend Improvements or additions to the frontend api Improvements or additions to the backend API labels Jan 10, 2025
@daryllimyt daryllimyt merged commit b4ae816 into main Jan 10, 2025
9 checks passed
@daryllimyt daryllimyt deleted the feat/tighten-input-validation branch January 10, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topher-lo topher-lo topher-lo approved these changes

Assignees
No one assigned
Labels
api Improvements or additions to the backend API enhancement New feature or request frontend Improvements or additions to the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daryllimyt @topher-lo