Hardened some functions which could throw exceptions

Tracktion · Jan 17, 2025 · 597b227 · 597b227
1 parent 295e57b
commit 597b227
Showing 11 changed files with 53 additions and 16 deletions.
diff --git a/modules/tracktion_engine/audio_files/tracktion_AudioFile.cpp b/modules/tracktion_engine/audio_files/tracktion_AudioFile.cpp
@@ -229,7 +229,7 @@ AudioProxyGenerator::GeneratorJob::GeneratorJob (const AudioFile& p)
 AudioProxyGenerator::GeneratorJob::~GeneratorJob()
 {
     prepareForJobDeletion();
-    callBlocking ([this] { proxy.engine->getAudioFileManager().validateFile (proxy, false); });
+    callBlockingCatching ([this] { proxy.engine->getAudioFileManager().validateFile (proxy, false); });
 }
 
 juce::ThreadPoolJob::JobStatus AudioProxyGenerator::GeneratorJob::runJob()

diff --git a/modules/tracktion_engine/model/automation/tracktion_AutomationRecordManager.cpp b/modules/tracktion_engine/model/automation/tracktion_AutomationRecordManager.cpp
@@ -37,6 +37,7 @@ AutomationRecordManager::AutomationRecordManager (Edit& ed)
         }
         else
         {
+            // Exception will be caught by the Edit constructor
             callBlocking ([this] { edit.getTransport().addChangeListener (this); });
         }
     }

diff --git a/modules/tracktion_engine/model/automation/tracktion_Modifier.cpp b/modules/tracktion_engine/model/automation/tracktion_Modifier.cpp
@@ -233,6 +233,7 @@ ModifierList::ModifierList (Edit& e, const juce::ValueTree& parentTree)
       edit (e), state (parent)
 {
     jassert (parent.hasType (IDs::MODIFIERS));
+    // Exception will be caught by Edit constructor
     callBlocking ([this] { rebuildObjects(); });
 }
 

diff --git a/modules/tracktion_engine/model/clips/tracktion_AudioClipBase.cpp b/modules/tracktion_engine/model/clips/tracktion_AudioClipBase.cpp
@@ -299,6 +299,7 @@ void AudioClipBase::initialise()
             setCurrentSourceFile (audioFile.getFile());
     }
 
+    // Exception will be caught by Edit constructor
     if (! edit.getUndoManager().isPerformingUndoRedo())
         callBlocking ([this] { setLoopDefaults(); });
 }

diff --git a/modules/tracktion_engine/model/clips/tracktion_AudioSegmentList.cpp b/modules/tracktion_engine/model/clips/tracktion_AudioSegmentList.cpp
@@ -138,7 +138,7 @@ std::unique_ptr<AudioSegmentList> AudioSegmentList::create (AudioClipBase& acb,
                           wtm.getWarpEndMarkerTime());
 
         juce::Array<TimeRange> warpTimeRegions;
-        callBlocking ([&] { warpTimeRegions = wtm.getWarpTimeRegions (region); });
+        callBlockingCatching ([&] { warpTimeRegions = wtm.getWarpTimeRegions (region); });
         auto position = warpTimeRegions.size() > 0 ? warpTimeRegions.getUnchecked (0).getStart() : TimePosition();
 
         for (auto warpRegion : warpTimeRegions)

diff --git a/modules/tracktion_engine/model/clips/tracktion_ClipEffects.cpp b/modules/tracktion_engine/model/clips/tracktion_ClipEffects.cpp
@@ -390,8 +390,17 @@ struct AudioNodeRenderJob  : public ClipEffect::ClipEffectRenderJob
     bool setUpRender() override
     {
         CRASH_TRACER
-        callBlocking ([this] { createAndPrepareRenderContext(); });
-        return true;
+        try
+        {
+            callBlocking ([this] { createAndPrepareRenderContext(); });
+            return true;
+        }
+        catch (std::runtime_error& err)
+        {
+            TRACKTION_LOG_ERROR (err.what());
+        }
+
+        return false;
     }
 
     bool renderNextBlock() override
@@ -1259,18 +1268,18 @@ struct PluginUnloadInhibitor    : private juce::Timer
 
     void load()
     {
-        callBlocking ([this]() { plugin->setProcessingEnabled (true); callback(); });
+        callBlockingCatching ([this] { plugin->setProcessingEnabled (true); callback(); });
     }
 
     void unload()
     {
-        callBlocking ([this]() { plugin->setProcessingEnabled (false); callback(); });
+        callBlockingCatching ([this] { plugin->setProcessingEnabled (false); callback(); });
     }
 
     int count = 0;
     Plugin::Ptr plugin;
     juce::ReferenceCountedArray<AudioNodeRenderJob> jobs;
-    std::function<void(void)> callback;
+    std::function<void()> callback;
 
     JUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR (PluginUnloadInhibitor)
 };
@@ -1294,6 +1303,7 @@ PluginEffect::PluginEffect (const juce::ValueTree& v, ClipEffects& o)
     if (pluginState.isValid())
     {
         pluginState.setProperty (IDs::process, false, nullptr); // always restore plugin to non-processing state on load
+        // Exception will be caught by Edit constructor
         callBlocking ([this, pluginState]() { plugin = edit.getPluginCache().getOrCreatePluginFor (pluginState); });
     }
 
@@ -1753,11 +1763,11 @@ struct AggregateJob  : public RenderManager::Job
                 afm.releaseFile (currentJob->destination);
 
                 if (! currentJob->destination.isNull())
-                    callBlocking ([&afm, fileToValidate = currentJob->destination]
-                                  {
-                                      afm.validateFile (fileToValidate, true);
-                                      jassert (fileToValidate.isValid());
-                                  });
+                    callBlockingCatching ([&afm, fileToValidate = currentJob->destination]
+                                          {
+                                              afm.validateFile (fileToValidate, true);
+                                              jassert (fileToValidate.isValid());
+                                          });
 
                 lastFile = currentJob->destination.getFile();
                 currentJob = nullptr;

diff --git a/modules/tracktion_engine/playback/graph/tracktion_NodeRenderContext.cpp b/modules/tracktion_engine/playback/graph/tracktion_NodeRenderContext.cpp
@@ -163,10 +163,17 @@ NodeRenderContext::~NodeRenderContext()
     if (writer != nullptr)
         writer->closeForWriting();
 
-    callBlocking ([this] { nodePlayer.reset(); });
+    try
+    {
+        callBlocking ([this] { nodePlayer.reset(); });
 
-    if (needsToNormaliseAndTrim)
-        owner.performNormalisingAndTrimming (originalParams, r);
+        if (needsToNormaliseAndTrim)
+            owner.performNormalisingAndTrimming (originalParams, r);
+    }
+    catch (std::runtime_error& err)
+    {
+        TRACKTION_LOG_ERROR (err.what());
+    }
 }
 
 bool NodeRenderContext::renderNextBlock (std::atomic<float>& progressToUpdate)

diff --git a/modules/tracktion_engine/plugins/external/tracktion_ExternalPlugin.cpp b/modules/tracktion_engine/plugins/external/tracktion_ExternalPlugin.cpp
@@ -1089,7 +1089,7 @@ void ExternalPlugin::restorePluginStateFromValueTree (const juce::ValueTree& v)
         chunk.fromBase64Encoding (s);
 
         if (chunk.getSize() > 0)
-            callBlocking ([&pi, &chunk] { pi->setStateInformation (chunk.getData(), (int) chunk.getSize()); });
+            callBlockingCatching ([&pi, &chunk] { pi->setStateInformation (chunk.getData(), (int) chunk.getSize()); });
     }
 }
 

diff --git a/modules/tracktion_engine/plugins/internal/tracktion_RackType.cpp b/modules/tracktion_engine/plugins/internal/tracktion_RackType.cpp
@@ -46,6 +46,7 @@ struct RackType::RackPluginList  : public ValueTreeObjectList<RackType::PluginIn
         : ValueTreeObjectList<PluginInfo> (parentTree), type (t)
     {
         CRASH_TRACER
+        // Exception will be caught by the Edit constructor
         callBlocking ([this] { this->rebuildObjects(); });
     }
 
@@ -151,6 +152,7 @@ struct RackType::WindowStateList  : public ValueTreeObjectList<WindowState>
         : ValueTreeObjectList<WindowState> (t.state), type (t)
     {
         CRASH_TRACER
+        // Exception will be caught by the Edit constructor
         callBlocking ([this] { this->rebuildObjects(); });
     }
 

diff --git a/modules/tracktion_engine/plugins/tracktion_PluginList.cpp b/modules/tracktion_engine/plugins/tracktion_PluginList.cpp
@@ -94,6 +94,7 @@ void PluginList::initialise (const juce::ValueTree& v)
 
     state = v;
     list = std::make_unique<ObjectList> (*this, state);
+    // Exception will be caught by the Edit constructor
     callBlocking ([this] { list->rebuildObjects(); });
 }
 

diff --git a/modules/tracktion_engine/utilities/tracktion_AsyncFunctionUtils.h b/modules/tracktion_engine/utilities/tracktion_AsyncFunctionUtils.h
@@ -288,5 +288,19 @@ inline bool callBlocking (std::function<void()> f)
     return true;
 }
 
+/** The same as callBlocking expect the exception is caught and ignored.
+    Use this when failue is ok.
+*/
+inline bool callBlockingCatching (std::function<void()> f) noexcept
+{
+    try
+    {
+        return callBlocking (std::move (f));
+    }
+    catch (std::runtime_error&)
+    {
+        return false;
+    }
+}
 
 }} // namespace tracktion { inline namespace engine
-Original file line number
+Diff line change
@@ @@ -37,6 +37,7 @@ AutomationRecordManager::AutomationRecordManager (Edit& ed) @@
             }
             else
             {
+                // Exception will be caught by the Edit constructor
                 callBlocking ([this] { edit.getTransport().addChangeListener (this); });
             }
         }