feat: legal page #824
Merged
feat: legal page #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tradetrust-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
superical
reviewed
Sep 20, 2023
| <a | ||
| download={TRADETRUST_LEGAL_ARTICLE_TITLE} | ||
| href="/static/images/legality/tradetrust-legal-article.pdf" | ||
| onClick={downloadArticle} |
There was a problem hiding this comment.
Pretty sure the click count for this will be very high!😄
Comment on lines
+13
to
+15
| <meta | ||
| name="keywords" | ||
| content="Blockchain, NFT, Ethereum, Electronic Trade Document, Verifiable Document, Digital Trade Document, Transferable Documents, Electronic Transactions Act, Bill of Lading" |
There was a problem hiding this comment.
Do we have a parent component to house these common meta tags for all pages?
There was a problem hiding this comment.
if so i think i can refactor the meta data to here, then have a common "head" component. Or do you any other idea in mind?
There was a problem hiding this comment.
Just thought in case we have a parent component and missed it in this PR only, don’t think it’s necessary to implement it into this PR if we don’t already have one.
osslgtm
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Legal analysis page
Changes
Issues
https://www.pivotaltracker.com/story/show/185938637