Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hedera): added support for hedera network #845

Closed
wants to merge 12 commits into from

Conversation

piruthivi3232
Copy link

added mainnet and testnet hedera network configurations.

Summary

feat(hedera): added support for hedera network by krypc

Changes

  • added mainnet and testnet hedera network configurations.

@superical
Copy link
Contributor

superical commented Dec 11, 2023

Please update branch and fix errors.

piruthivi3232 and others added 2 commits December 11, 2023 12:23
@piruthivi3232
Copy link
Author

errors fixed.

@superical
Copy link
Contributor

Pls post some screenshots of the frontend to show that you have tested it and that it's working on KrypC's desired blockchain. Thanks.

@piruthivi3232
Copy link
Author

screen1
screen2
screen3
screen4
screen5

screenshot added for your reference

@isaackps
Copy link
Contributor

Thank you for the screenshots,
next step is to include the tests:

  • Display - Owner, Holder, Surrender Status, Endorsement Chain
  • Status Checks - Issuance Check -> Validity check on smart contract(Document Store & Token Registry), Issuer Check -> DNS Records, Tamper Check -> hash corresponds to Document
  • transfers - Transfer Owners, Transfer holder
  • owner Change Request - Nominate owner, Endorse owner
  • Surrender - Surrender, Accept Surrender, Reject Surrender
  • User Flow with Roles - Transfer Owners -> both owner and holder in a single transaction, nominate (by owner) then endorse nomination (by holder), surrender (by owner and holder) then accept surrender (by ACCEPTOR_ROLE), surrender (by owner and holder) then reject surrender (by RESTORER_ROLE)

@piruthivi3232
Copy link
Author

We just need to add the test cases, correct?

@isaackps
Copy link
Contributor

Yes, the changes looks good, just need to update the test cases for this repo.

@isaackps
Copy link
Contributor

Hi,
can you add in a demo TT document too, thanks

@isaackps isaackps closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants