Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): add support for Stability Testnet #857

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

deblanco
Copy link
Contributor

@deblanco deblanco commented Jan 10, 2024

Summary

This PR adds support for Stability Testnet network.

This PR is pending other PR related to the TradeTrust pkg to update the package.json dependency: TradeTrust/token-registry#4

Changes

  • Chain configs

Issues

NA

For further information, please reach the following email: [email protected]

@deblanco deblanco changed the title [WIP] - feat(network): add support for Stability Testnet eat(network): add support for Stability Testnet Feb 20, 2024
@deblanco deblanco changed the title eat(network): add support for Stability Testnet feat(network): add support for Stability Testnet Feb 20, 2024
@deblanco
Copy link
Contributor Author

deblanco commented Feb 20, 2024

@isaackps, we have all the changes ready, but we found a problem with the tests; we need some advice on your part:

image

One updated dependency is @tradetrust-tt/verify , which imports @tradetrust-tt/dnsprove and internally uses axios.
Axios, since version 1.X.X changed the module type from CJS to ECMAScript or ES modules, where the problems begin.

This problem is also happening because the last update on @tradetrust/dnsprove, v2.10.1, has been released as a Patch and npm is ignoring the package-lock.json then, installing the v2.10.1 version instead of the v2.10.0 (https://github.com/TradeTrust/tt-verify/blob/master/package-lock.json#L3811)

There are some solutions for this problem:

Some more info: https://stackoverflow.com/questions/73958968/cannot-use-import-statement-outside-a-module-with-axios

Thanks

@deblanco deblanco marked this pull request as ready for review February 20, 2024 08:55
@isaackps
Copy link
Contributor

Hi, thanks for letting me know about the problem, yes please proceed with your recommendation of adding it into the jest.config.js.

@deblanco
Copy link
Contributor Author

Hi, thanks for letting me know about the problem, yes please proceed with your recommendation of adding it into the jest.config.js.

ready, thanks!

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for tradetrust-mainnet ready!

Name Link
🔨 Latest commit 4b8bbbe
🔍 Latest deploy log https://app.netlify.com/sites/tradetrust-mainnet/deploys/65d4709294534e000842d6f0
😎 Deploy Preview https://deploy-preview-857--tradetrust-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@isaackps isaackps merged commit 5a57c0a into TradeTrust:master Feb 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants