Update Dockerfile with Laravel PHP extensions needed #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://laravel.com/docs/10.x/deployment#server-requirements I think it is relevant since is the most popular framework these days. xmlwriter is needed for Laravel Sanctum.
|
Related to #148 |
|
Hi @insign , Thank you for your contribution. Although I hold back on adding extensions to keep the base image as small as possible, these extensions are part of what's bundled with PHP (except for xmlwriter, but we also have xmlreader so it's not adding any overhead). So I'll be happy to merge this! |
|
I truly understand that you want a very simple and clean image but have composer looks like a must. I saw in the documentation how to add but keeps the sensation that is so needed because even small projects should rely on composer to keeps things tidy. |
|
And... like others images since the deploy is automated could have a image**-dev** with debug enable by default (even I not use it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://laravel.com/docs/10.x/deployment#server-requirements
I think it is relevant since is the most popular framework these days.
xmlwriter is needed for Laravel Sanctum.