Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added instructions to enable https/ssl #157

Closed
wants to merge 6 commits into from
Closed

Conversation

insign
Copy link
Contributor

@insign insign commented Nov 14, 2023

No description provided.

Copy link
Owner

@TrafeX TrafeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Just spotted a small spell error

}
```

If you use docker-compose here a example:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated my branch but I just don't know how to update the current PR.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've pushed it to the patch-1 branch on your repository, the PR should automatically update. I think you've changed it on the master branch instead of the patch-1 branch

@insign
Copy link
Contributor Author

insign commented Nov 16, 2023 via email

@insign
Copy link
Contributor Author

insign commented Nov 17, 2023

Done. Please check again.

@TrafeX
Copy link
Owner

TrafeX commented Nov 17, 2023

With adding the typo fix, you also added the .gitignore changes. I rebased your branch and picked the correct commits to merge. It's now in master: 4073339
Thank you!

@TrafeX TrafeX closed this Nov 17, 2023
@insign
Copy link
Contributor Author

insign commented Nov 18, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants