Use model meta to generate verbose name #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Render field names of object rather than the word "None" This is fix for issue TrangPham#53, since an object may not exist when rendering `templates/admin/change_data.html` - ie, if we're greating a new object when `confirm_add = True` is set on a `ModelAdmin` with the `AdminConfirmMixin`. Also makes sure we send an actual object (not the string "None") to the base template, to remove other instances of the word "None" from the add view.
|
Thanks for your contribution! Do tests already exist for this? If not could you add a test case that would have failed before but now passes? |
|
Edit: my DecimalField blow up was my own fault. 😝 I'll look into adding tests. |
|
Thanks. Let me know if you need support with either the tests or debugging your decimal issue. If you found the reason you had issues with decimals, can you share that? I'll be able to help others if they face a similar issue if I know what happened. |
|
Hi @TrangPham - I ended up not using django-admin-confirm for my project, so I'm not sure I'll have time ot prepare test cases. Thanks! |
TrangPham
added
good first issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render field names of object rather than the word "None"
This is fix for issue #53, since an object may not exist when rendering
templates/admin/change_data.html- ie, if we're greating a new objectwhen
confirm_add = Trueis set on aModelAdminwiththe
AdminConfirmMixin.Also makes sure we send an actual object (not the string "None") to the
base template, to remove other instances of the word "None" from
the add view.
Uses capitalize on the string, as that seems to be the pattern in Django admin.
Fixes
Tested via: