Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py.typed for type hints #760

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

UFO-101
Copy link
Contributor

@UFO-101 UFO-101 commented Oct 18, 2024

Description

I think that all libraries are supposed to include a py.typed file for types to be accessible to external users. See: https://blog.whtsky.me/tech/2021/dont-forget-py.typed-for-your-typed-python-package/.

However, I haven't researched this thoroughly, so someone should probably look into this a bit more.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

…and adjust the cross entropy calculation to ignore masked (padding) tokens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant