-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow libloading
v0.7 and v0.8
#69
Allow libloading
v0.7 and v0.8
#69
Conversation
19b3ec1
to
b4fc14a
Compare
I'm not sure if this is necessary for wgpu, since hassle-rs is behind an optional feature that afaik mozilla doesn't enable. |
Either way, hassle-rs brings windows into the dep tree, so until moz figures out windows-rs, we can't use fully depend on hassle-rs. I would vote this as unnecessary. |
Alright, thanks! |
@cwfitzgerald where does it bring this in (prior to #67) exactly? Searching for |
You know what, I just totally confused hassle-rs for gpu-allocator 🤦🏻♂️ Let's re-open and merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, though I hope we're migrating away from winapi
now 😉
Updated situation from mozilla land is that windows-sys 0.48.0 is allowed, but |
@cwfitzgerald if we were to use |
Yeah now that I'm putting it all together, this doesn't matter:
I think I got hassle-rs and gpu-allocator confused again |
The only relevant change in v0.8 is the migration to
windows-sys
: https://docs.rs/libloading/0.8.0/libloading/changelog/r0_8_0/index.html.This is done in the same spirit as gfx-rs/wgpu#3711 because I heard Mozilla, who is using
wgpu
, isn't ready to migrate towindows-sys
yet, see gfx-rs/wgpu#3207.d3d12
did this as well: gfx-rs/d3d12-rs#43.Originally coming from here: #67 (comment).