runtime: Disable default link feature on metal crate
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're only using a few types from the `metal` crate, this helper library has no reason or need to link against framework libraries (i.e. we don't call global static functions on them). Disable the `link` feature on the `metal` crate, but note that for now this won't disable it on the `core-graphics-types` crate until gfx-rs/metal-rs#330 is merged.
MarijnS95
force-pushed
the
runtime-no-link
branch
from
daa2cc3
to
33afa36
Compare
tosti007
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're only using a few types from the
metalcrate, this helper library has no reason or need to link against framework libraries (i.e. we don't call global static functions on them). Disable thelinkfeature on themetalcrate.Caution
For now this won't disable it on the
core-graphics-typescrate until gfx-rs/metal-rs#330 is merged.