-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite lancelot debugging stuff #71
base: android-14.0
Are you sure you want to change the base?
Conversation
Conflicts with SurfaceFlinger durations from MIUI 13. Causes blank display if GSI is installed on top of MIUI 12 vendor.
Causes apps like Chrome and Youtube to set the frame rate to 30 FPS. This causes lag when displayed on media controls.
To improve system smoothness.
bc21889
to
038c7f0
Compare
I don't have the needed knowledge to know if this makes sense at all or not. Off-topic: please don't tag me on a daily basis to get your PR merged asap... |
Sorry Ponces for bothering you. Yes, I see the difference especially the graphics I think the benchmark scores are reliable. MIUI 12 (A11) vendor does not have the non-working audio on calls issue while MIUI 13 (A12) vendor does. The only drawback of MIUI 12 (A11) vendor is the screen recording issue that does not work. |
Also this does not mean that GSI cannot be installed on MIUI 13 vendor after this PR. I just got rid of the useless debugging stuff with this situation so that it benefits both (when using MIUI 13 vendor or MIUI 12 vendor). |
I just realized that for GSI, MIUI 12 (A11) vendor has much better performance compared to MIUI 13 (A12) vendor.
So I decided to retest the existing properties and rewrite them as they are now.
Removed:
debug.renderengine.backend skiaglthreaded
> causes benchmark score to drop on MIUI 12 vendor.debug.sf.predict_hwc_composition_strategy 0
> causes benchmark score to drop on MIUI 12 vendor.debug.stagefright.c2inputsurface -1
> causes error when starting screen recording on MIUI 12 vendor.media.stagefright.thumbnail.prefer_hw_codecs true
> unclear whether it works or not.Added:
resetprop_phh --delete ro.surface_flinger.vsync_event_phase_offset_ns
resetprop_phh --delete ro.surface_flinger.vsync_sf_event_phase_offset_ns
^
From vendor/build.prop on MIUI 12.
Conflicts with SurfaceFlinger durations from MIUI 13.
Need to be removed so that the display is not blank when GSI is installed on top of MIUI 12 vendor.
With this configuration, MIUI 12 vendor scores about 250 points more than MIUI 13 vendor on 3DMARK Sling Shot.
For MIUI 13 vendor, no changes.
I also updated the Redmi 9 presets to complement this.
TrebleDroid/treble_presets#13