Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite lancelot debugging stuff #71

Open
wants to merge 5 commits into
base: android-14.0
Choose a base branch
from

Conversation

wildbeetle
Copy link

I just realized that for GSI, MIUI 12 (A11) vendor has much better performance compared to MIUI 13 (A12) vendor.
So I decided to retest the existing properties and rewrite them as they are now.

Removed:
debug.renderengine.backend skiaglthreaded > causes benchmark score to drop on MIUI 12 vendor.
debug.sf.predict_hwc_composition_strategy 0 > causes benchmark score to drop on MIUI 12 vendor.
debug.stagefright.c2inputsurface -1 > causes error when starting screen recording on MIUI 12 vendor.
media.stagefright.thumbnail.prefer_hw_codecs true > unclear whether it works or not.

Added:
resetprop_phh --delete ro.surface_flinger.vsync_event_phase_offset_ns
resetprop_phh --delete ro.surface_flinger.vsync_sf_event_phase_offset_ns
^
From vendor/build.prop on MIUI 12.
Conflicts with SurfaceFlinger durations from MIUI 13.
Need to be removed so that the display is not blank when GSI is installed on top of MIUI 12 vendor.

With this configuration, MIUI 12 vendor scores about 250 points more than MIUI 13 vendor on 3DMARK Sling Shot.
For MIUI 13 vendor, no changes.

I also updated the Redmi 9 presets to complement this.
TrebleDroid/treble_presets#13

@wildbeetle wildbeetle changed the title Update lancelot debugging stuff Rewrite lancelot debugging stuff Aug 21, 2024
Conflicts with SurfaceFlinger durations from MIUI 13.
Causes blank display if GSI is installed on top of MIUI 12 vendor.
Causes apps like Chrome and Youtube to set the frame rate to 30 FPS.
This causes lag when displayed on media controls.
@wildbeetle
Copy link
Author

Please merge @phhusson @ponces
Thanks.

@ponces
Copy link

ponces commented Aug 26, 2024

I don't have the needed knowledge to know if this makes sense at all or not.
My only question is: is that "performance increase" really noticeable on your daily usage?
Or are you only caring about (in my opinion) some questionable benchmark results?

Off-topic: please don't tag me on a daily basis to get your PR merged asap...

@wildbeetle
Copy link
Author

Sorry Ponces for bothering you.

Yes, I see the difference especially the graphics

I think the benchmark scores are reliable.
I once made an issue in your aosp repository about lag on the trebuchet launcher (I have closed it).
It happens when I install GSI on top of MIUI 13 (A12) vendor.
But not when I install GSI on top of MIUI 12 (A11) vendor.
Also it is smoother when browsing and gaming with MIUI 12 (A11) vendor.

MIUI 12 (A11) vendor does not have the non-working audio on calls issue while MIUI 13 (A12) vendor does.
Also the echo issue on MIUI 12 (A11) vendor is not as bad as on MIUI 13 (A12)

The only drawback of MIUI 12 (A11) vendor is the screen recording issue that does not work.
Actually there is a way but it breaks the screen recording function of MIUI 13 (A12) vendor.
So I did not include it in the PR.

@wildbeetle
Copy link
Author

Also this does not mean that GSI cannot be installed on MIUI 13 vendor after this PR.
instead this PR is to fix the blank display when installed on MIUI 12 vendor.
So we have a choice whether to install GSI on MIUI 13 vendor or MIUI 12 vendor later.

I just got rid of the useless debugging stuff with this situation so that it benefits both (when using MIUI 13 vendor or MIUI 12 vendor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants