Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redmi 9: Rewrite overlay based on official LineageOS #118

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

wildbeetle
Copy link

Big improvement especially auto brightness

@phhusson
Copy link

If it improvies auto brightness why do you change config_mobile_tcp_buffers ...

The main change is to improve auto brightness.
Slight tweaks to the status bar and added other things.
@wildbeetle
Copy link
Author

I have deleted networkAttributes, radioAttributes and config_mobile_tcp_buffers.

@wildbeetle wildbeetle closed this Jul 23, 2024
@phhusson
Copy link

Hmmm? Why all the closes?

@wildbeetle wildbeetle reopened this Jul 23, 2024
@wildbeetle
Copy link
Author

Hmmm? Why all the closes?

I'm making sure everything is correct.
Started without any debugging stuff on rw-system.sh.
Then try anything useful from Treble App.
Once everything is correct I will reopen them.

Now I reopen them again.

@phhusson
Copy link

Understood. The "standard" way to mark a PR "work in progress" is to prepend the name of the PR with "WIP:" like renaming yours to WIP: Redmi 9: Rewrite overlay based on official LineageOS

@wildbeetle
Copy link
Author

Ready to merge @phhusson

@phhusson phhusson merged commit 3429e25 into TrebleDroid:pie Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants