Added Overlay for Samsung Tab A8 #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
am down to rectify anything but i was not sure how to proceed and would love some guidance. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added files for tab a8. I found vendor has all 5 files i need (arrays, bools, dimens, integers, strings) but product has only two (bools and strings). So i took the two and compared and did everything well.
Is this correct or should i have done it differently?
Am following this guide:
https://github.com/phhusson/treble_experimentations/wiki/How-to-create-an-overlay%3F#comparing-the-product-and-vendor-overlays
Other than that everything else is fine.