Update to the latest codebase of treblle and golang version #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where requests sent to the Treblle service weren't being registered. The problem seemed to be related to outdated dependencies using an older version of the golang SDK for Gin.
I have updated the SDK to version 0.7.2 and adapted the code to comply with its latest behavior. This ensures that all requests, including those sent through GET and other methods, are now properly registered.
I've verified this fix by manual end-to-end test to confirm that all expected requests are being logged correctly.
Please review the changes and let me know if you have any questions.