Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementa Registro de Mandato de Sindico #108

Merged
merged 14 commits into from
Jul 21, 2024
Merged

Implementa Registro de Mandato de Sindico #108

merged 14 commits into from
Jul 21, 2024

Conversation

luckslima
Copy link
Contributor

@luckslima luckslima commented Jul 18, 2024 •
edited by DaniloRibeiro07
Loading

Introdução

Neste PR implementamos o cadastro de Síndico de um condomínio. Um administrador super ou associado ao condomínio pode, agora, através da barra lateral clicar em cadastrar um síndico e escolher o condomínio para vínculo.

Objetivos

  • Criar acesso rápido a cadastro de síndico na barra lateral de administrador
  • Criar página e formulário de cadastro de síndico
  • Criar página de detalhes de síndico
  • Criar página e formulário de edição de síndico
  • Exibe o nome do síndico atual com um link na página de detalhes do condomínio
  • Estabelecer autorização e proteção para as novas rotas

Telas

Localização do cadastro de síndico no nav bar
Navbar Cadastro de síndico

Modal para selecionar o condomínio onde será cadastrado o síndico
Selecionar o Condomínio no modal

Formulário de cadastro e edição do síndico
Formulário de cadastro do síndico

Página de perfil do síndico
Página de perfil do síndico

Informações do síndico e link de redirecionamento para o perfil do síndico abaixo do CNPJ do dashboard do condominio.
Sindico dashboard

Caso algum administrador tente cadastrar um síndico para um condominio que já possua síndico, o adm será redicionado para o perfil do atual síndico.
Redirect cadastro de síndico

@luckslima luckslima added the enhancement New feature or request label Jul 18, 2024
@luckslima luckslima linked an issue Jul 18, 2024 that may be closed by this pull request
Cadastrar mandato de síndico #21
Closed
3 tasks
@luckslima luckslima marked this pull request as ready for review July 18, 2024 02:26
RSalgado-dev
RSalgado-dev approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@RSalgado-dev RSalgado-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ta bem legal a implementacao. Deixei alguns comentarios para voces avaliarem.

Nao vi testes que mostram oque acontece quando a data vigente do sindico expira

app/controllers/superintendents_controller.rb Outdated Show resolved Hide resolved
app/views/shared/_navbar.html.erb Outdated Show resolved Hide resolved
spec/requests/manager_edit_superintendent_spec.rb Outdated Show resolved Hide resolved
Vinigperuzzi
Vinigperuzzi approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@Vinigperuzzi Vinigperuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isso aí, pessoal. Deixei minha review, apesar de que vou ter que revisar de novo depois do merge e da resolução dos conflitos.

app/controllers/application_controller.rb Outdated Show resolved Hide resolved
app/models/superintendent.rb Outdated Show resolved Hide resolved
app/views/shared/_navbar.html.erb Outdated Show resolved Hide resolved
app/views/superintendents/_form.html.erb Outdated Show resolved Hide resolved
app/views/superintendents/show.html.erb Outdated Show resolved Hide resolved
spec/requests/manager_edit_superintendent_spec.rb Outdated Show resolved Hide resolved
lucasobx
lucasobx approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@lucasobx lucasobx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixando aprovado! Só lembrem de checar os comentários e resolver os conflitos de autorização com a main.

spec/requests/manager_edit_superintendent_spec.rb Show resolved Hide resolved
lucasobx
lucasobx approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@lucasobx lucasobx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei mais um comentário sobre refatoração dos testes!

spec/requests/manager_edit_superintendent_spec.rb Show resolved Hide resolved
RSalgado-dev
RSalgado-dev approved these changes Jul 21, 2024
View reviewed changes
Copy link
Contributor

@RSalgado-dev RSalgado-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aparentemente tudo ok!

@DaniloRibeiro07 DaniloRibeiro07 merged commit bea3b4b into main Jul 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cellaaleo cellaaleo cellaaleo left review comments

@Vinigperuzzi Vinigperuzzi Vinigperuzzi approved these changes

@lucasobx lucasobx lucasobx approved these changes

@RSalgado-dev RSalgado-dev RSalgado-dev approved these changes

@akaninja akaninja Awaiting requested review from akaninja

@ruliancruz ruliancruz Awaiting requested review from ruliancruz

@gabdemiranda gabdemiranda Awaiting requested review from gabdemiranda

@thalytalima211 thalytalima211 Awaiting requested review from thalytalima211

Assignees

@DaniloRibeiro07 DaniloRibeiro07

@luckslima luckslima

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cadastrar mandato de síndico
6 participants
@luckslima @RSalgado-dev @lucasobx @Vinigperuzzi @cellaaleo @DaniloRibeiro07