Slrt #16
Merged
Slrt #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
krystian-hebel
force-pushed
the
shrink_measured_size
branch
from
602004f
to
1019f11
Compare
krystian-hebel
force-pushed
the
slrt
branch
2 times, most recently
from
1148be4
to
f2a18cb
Compare
SergiiDmytruk
approved these changes
Mar 5, 2024
krystian-hebel
force-pushed
the
shrink_measured_size
branch
from
1019f11
to
cb2b08a
Compare
krystian-hebel
force-pushed
the
shrink_measured_size
branch
from
cb2b08a
to
d8ac246
Compare
krystian-hebel
force-pushed
the
shrink_measured_size
branch
from
d8ac246
to
67853db
Compare
pm_kernel_entry and zero_page were renamed to dlme_entry and dlme_arg, respectively. Their previous names were valid only for Linux. Signed-off-by: Krystian Hebel <[email protected]>
Linux, Multiboot2 and simple payload don't have overlapping uses for values passed through registers or stack. All of those can be set at the same time. Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Krystian Hebel <[email protected]>
SKL hashes are no longer passed from the bootloader. Measured code and read-only data are not changed, and all other data is created at runtime so SKL is able to measure itself, which it now does. Those hashes are only used for event log entries, PCR was extended as a result of SKINIT instruction on Dynamic Launch Event. Signed-off-by: Krystian Hebel <[email protected]>
This removes different handling between boot protocols. Everything is reduced to one range of consecutive memory for DLME, as well as pointer to the entry point, which is measured to PCR 17 as an offset from DLME base to avoid attacks based on jumping to different parts of DLME. Signed-off-by: Krystian Hebel <[email protected]>
Signed-off-by: Krystian Hebel <[email protected]>
MULTIBOOT2_BOOTLOADER_MAGIC has been moved to defs.h as it is still used in head.S. Signed-off-by: Krystian Hebel <[email protected]>
It used to be defined in boot.h, even though it isn't expected to be ever needed anywhere but in code for handling event log internally. Signed-off-by: Krystian Hebel <[email protected]>
rossphilipson
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
I think this should go in now. There may be changes to the SLRT and ABI but this moves us forward.
Thanks
Reviewed-by: Ross Philipson [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.