fix: Fix carousel click problem #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasangenc0
reviewed
Feb 3, 2023
| @@ -61,13 +61,11 @@ export const ScrollingCarousel: FunctionComponent<SliderProps> = ({ | |||
| const mouseUp = (_: MouseEvent) => { | |||
| setIsDown(false); | |||
| setShowArrow(showArrows()); | |||
| slider.current!.classList.remove(styles.sliding); | |||
There was a problem hiding this comment.
if you remove this line, the element that is targeted for this mouseUp event will ultimately trigger the onClick event and it will cause <a> elements to trigger a navigation while you still sliding. Check this feature if it's what you are trying to solve, and it can be implemented for this component too.
There was a problem hiding this comment.
I added the triggerClickOn prop as in carousel component. Could you review this again?
minel
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/workflows/PULL_REQUEST_TEMPLATE.md