Skip to content

Commit

Permalink
Merge pull request #233 from Tresjs/bugfix/229-tresbuffergeometry-get…
Browse files Browse the repository at this point in the history
…-broken-with-the-last-tresjs-update-attributes-assign

fix: avoid assigning args as BufferAttribute to BufferGeometry
  • Loading branch information
alvarosabu authored Apr 25, 2023
2 parents 5a5ae78 + 1cc67b0 commit b3fdc29
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/core/nodeOps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ export const nodeOps: RendererOptions<TresObject, TresObject> = {
let target = root?.[finalKey]

if (root.type === 'BufferGeometry') {
if (key === 'args') return
root.setAttribute(
kebabToCamel(key),
new BufferAttribute(...(nextValue as ConstructorParameters<typeof BufferAttribute>)),
Expand Down

0 comments on commit b3fdc29

Please sign in to comment.