feat: renamed useCamera composable methods to prevent confusion #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Tinoooo
changed the title
|
@Tinoooo to be fair I never saw this composable to be exportable at all, only for internal use 🤔 |
|
@Tinoooo could you please check the conflict, maybe that will clean up the PR a bit |
…methods-of-the-usecamera-composable-to-prevent-confusion
@alvarosabu done |
…methods-of-the-usecamera-composable-to-prevent-confusion
…methods-of-the-usecamera-composable-to-prevent-confusion
alvarosabu
approved these changes
Sep 5, 2023
Tinoooo
deleted the
feature/379-renaming-methods-of-the-usecamera-composable-to-prevent-confusion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So technically the the change I made is a breaking change. But since the methods are not that old and I'd imagine they are not used by anybody yet, I'd say there is no need to bump the major version of core.